Add onewire #38
Open
Add onewire #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file and test_main.ino. Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request adds tests for the OneWire sensor by introducing new test cases and supporting build targets for verifying device connection, chip description, and data retrieval.
- Added a preprocessor block in the main test file to run onewire sensor tests.
- Created a new test file with three test cases for OneWire sensor functionality.
- Updated the Makefile to include a target for the OneWire sensor tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test_main.ino | Added preprocessor condition to run onewire sensor tests. |
| src/corelibs/onewire/test_onewire_sensor.cpp | Added new tests for device presence, chip description, and data retrieval on OneWire bus. |
| Makefile | Introduced a new target for OneWire sensor tests. |
Comment on lines
+11
to
+12
| // OneWire instance and variables | ||
| static OneWire oneWire(5); // Pin 5 is used for the OneWire bus |
There was a problem hiding this comment.
[nitpick] Consider defining a named constant for the OneWire bus pin instead of using the hard-coded value (5) to enhance code readability and ease future modifications.
Suggested change
| // OneWire instance and variables | |
| static OneWire oneWire(5); // Pin 5 is used for the OneWire bus | |
| // Define the pin used for the OneWire bus | |
| constexpr int ONE_WIRE_BUS_PIN = 5; | |
| // OneWire instance and variables | |
| static OneWire oneWire(ONE_WIRE_BUS_PIN); // Use named constant for the OneWire bus pin |
Copilot uses AI. Check for mistakes.
Signed-off-by: Frederikwag <[email protected]>
Signed-off-by: Frederikwag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Added the OneWire-Test. Therefore, 3 tests are executed:
Related Issue
Context